Catch Blocks

apps/core-server/modules/chron.ts

@@ -142,73 +142,77 @@ const removeConnectedAircrafts = async () => {
 	});
 };
 const removePermissionsForBannedUsers = async () => {
-	const removePermissionsPenaltys = await prisma.penalty.findMany({
-		where: {
-			removePermissionApplied: false,
-			User: {
-				DiscordAccount: { isNot: null },
-			},
-		},
-		include: {
-			User: {
-				include: {
-					DiscordAccount: true,
-					FormerDiscordAccounts: true,
+	try {
+		const removePermissionsPenaltys = await prisma.penalty.findMany({
+			where: {
+				removePermissionApplied: false,
+				User: {
+					DiscordAccount: { isNot: null },
 				},
 			},
-		},
-	});
-
-	const addPermissionsPenaltys = await prisma.penalty.findMany({
-		where: {
-			addPermissionApplied: false,
-			User: {
-				DiscordAccount: { isNot: null },
-			},
-			OR: [{ suspended: true }, { until: { lt: new Date().toISOString() } }],
-		},
-		include: {
-			User: {
-				include: {
-					DiscordAccount: true,
-					FormerDiscordAccounts: true,
+			include: {
+				User: {
+					include: {
+						DiscordAccount: true,
+						FormerDiscordAccounts: true,
+					},
 				},
 			},
-		},
-	});
+		});
 
-	for (const penalty of removePermissionsPenaltys) {
-		const user = penalty.User;
-		console.log(`Removing roles for user ${user.id} due to penalty ${penalty.id}`);
+		const addPermissionsPenaltys = await prisma.penalty.findMany({
+			where: {
+				addPermissionApplied: false,
+				User: {
+					DiscordAccount: { isNot: null },
+				},
+				OR: [{ suspended: true }, { until: { lt: new Date().toISOString() } }],
+			},
+			include: {
+				User: {
+					include: {
+						DiscordAccount: true,
+						FormerDiscordAccounts: true,
+					},
+				},
+			},
+		});
 
-		await changeMemberRoles(
-			user.DiscordAccount!.discordId,
-			[DISCORD_ROLES.PILOT, DISCORD_ROLES.DISPATCHER],
-			"remove",
-		);
+		for (const penalty of removePermissionsPenaltys) {
+			const user = penalty.User;
+			console.log(`Removing roles for user ${user.id} due to penalty ${penalty.id}`);
 
-		for (const formerAccount of user.FormerDiscordAccounts) {
 			await changeMemberRoles(
-				formerAccount.discordId,
+				user.DiscordAccount!.discordId,
 				[DISCORD_ROLES.PILOT, DISCORD_ROLES.DISPATCHER],
 				"remove",
 			);
+
+			for (const formerAccount of user.FormerDiscordAccounts) {
+				await changeMemberRoles(
+					formerAccount.discordId,
+					[DISCORD_ROLES.PILOT, DISCORD_ROLES.DISPATCHER],
+					"remove",
+				);
+			}
+			await prisma.penalty.update({
+				where: { id: penalty.id },
+				data: { removePermissionApplied: true },
+			});
 		}
-		await prisma.penalty.update({
-			where: { id: penalty.id },
-			data: { removePermissionApplied: true },
-		});
-	}
-	for (const penalty of addPermissionsPenaltys) {
-		console.log(`Restoring roles for user ${penalty.userId} due to penalty ${penalty.id}`);
-		await setUserStandardNamePermissions({
-			memberId: penalty.User.DiscordAccount!.discordId,
-			userId: penalty.userId,
-		});
-		await prisma.penalty.update({
-			where: { id: penalty.id },
-			data: { addPermissionApplied: true },
-		});
+		for (const penalty of addPermissionsPenaltys) {
+			console.log(`Restoring roles for user ${penalty.userId} due to penalty ${penalty.id}`);
+			await setUserStandardNamePermissions({
+				memberId: penalty.User.DiscordAccount!.discordId,
+				userId: penalty.userId,
+			});
+			await prisma.penalty.update({
+				where: { id: penalty.id },
+				data: { addPermissionApplied: true },
+			});
+		}
+	} catch (error) {
+		console.error("Error removing permissions for banned users:", error);
 	}
 };
 

apps/core-server/routes/helper.ts

@@ -66,6 +66,8 @@ export const setUserStandardNamePermissions = async ({
 	const publicUser = getPublicUser(user);
 	const member = await getMember(memberId);
 
+	if (!member) throw new Error("Member not found");
+
 	await member.setNickname(`${publicUser.fullName} - ${user.publicId}`);
 	const isPilot = user.permissions.includes("PILOT");
 	const isDispatcher = user.permissions.includes("DISPO");
@@ -79,10 +81,14 @@ export const setUserStandardNamePermissions = async ({
 };
 
 router.post("/set-standard-name", async (req, res) => {
-	const { memberId, userId } = req.body;
+	try {
+		const { memberId, userId } = req.body;
 
-	await setUserStandardNamePermissions({ memberId, userId });
-	res.status(200).json({ message: "Standard name and permissions set" });
+		await setUserStandardNamePermissions({ memberId, userId });
+		res.status(200).json({ message: "Standard name and permissions set" });
+	} catch (error) {
+		res.status(500).json({ error: (error as unknown as Error).message });
+	}
 });
 
 export default router;

apps/core-server/routes/member.ts

@@ -20,12 +20,12 @@ export const getMember = async (memberId: string) => {
 	try {
 		let member = guild.members.cache.get(memberId);
 		if (!member) {
-			member = await guild.members.fetch(memberId);
+			member = await guild.members.fetch(memberId).catch((e) => undefined);
 		}
 		return member;
 	} catch (error) {
 		console.error("Error fetching member:", error);
-		throw new Error("Member not found");
+		return null;
 	}
 };
 
@@ -37,6 +37,10 @@ router.post("/rename", async (req: Request, res: Response) => {
 	}
 	try {
 		const member = await getMember(memberId);
+		if (!member) {
+			res.status(404).json({ error: "Member not found" });
+			return;
+		}
 		await member.setNickname(newName);
 		console.log(`Member ${member.id} renamed to ${newName}`);
 		res.status(200).json({ message: "Member renamed successfully" });
@@ -52,6 +56,9 @@ export const changeMemberRoles = async (
 	action: "add" | "remove",
 ) => {
 	const member = await getMember(memberId);
+	if (!member) {
+		throw new Error("Member not found");
+	}
 
 	const currentRoleIds = member.roles.cache.map((role) => role.id);
 	const filteredRoleIds =